Skip to content

feat(metrics): [Trace Metrics 7] Metrics counter basic API #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adinauer merged 1 commit into from
Jan 14, 2026
Merged

feat(metrics): [Trace Metrics 7] Metrics counter basic API #4986

adinauer merged 1 commit into from
Jan 14, 2026
+212 −1

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Dec 22, 2025 •
edited
Loading

📜 Description

First API method for count Metrics. More overloads, gauge and distribution will be added in follow-up PRs.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

This was referenced Dec 22, 2025
Merged
Merged
Merged
Merged
@adinauer Graphite App
Copy link
Member Author

adinauer commented Dec 22, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 22, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025 •
edited
Loading

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- [Trace Metrics 7] Metrics counter basic API ([#4986](https://github.com/getsentry/sentry-java/pull/4986))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 38a5226

This was referenced Dec 22, 2025
Merged
Merged
@adinauer adinauer changed the title Metrics counter basic API feat(metrics): [Trace Metrics 7] Metrics counter basic API Dec 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 473.64 ms 549.88 ms 76.24 ms
Size 1.58 MiB 2.20 MiB 634.11 KiB

@adinauer adinauer force-pushed the 12-18-metrics_counter_basic_api branch from c2ff229 to 5dba18b Compare December 22, 2025 13:41
@adinauer adinauer force-pushed the 12-18-wire_up_metrics_parts branch from 5f9d714 to 1df9f12 Compare December 22, 2025 13:41
markushi
markushi approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was referenced Jan 8, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@adinauer adinauer force-pushed the 12-18-metrics_counter_basic_api branch from 5dba18b to 38a5226 Compare January 9, 2026 10:26
@adinauer adinauer force-pushed the 12-18-wire_up_metrics_parts branch from 1df9f12 to 4605172 Compare January 9, 2026 10:26
This was referenced Jan 9, 2026
Merged
Merged
Merged
Merged
Closed
Merged
Merged
@adinauer adinauer marked this pull request as ready for review January 14, 2026 05:58
@adinauer adinauer requested review from lcian and romtsn as code owners January 14, 2026 05:58
@adinauer
Copy link
Member Author

adinauer commented Jan 14, 2026

cursor review

@adinauer
Copy link
Member Author

adinauer commented Jan 14, 2026

@sentry review

cursor[bot]
cursor bot reviewed Jan 14, 2026
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

Base automatically changed from 12-18-wire_up_metrics_parts to feat/trace-metrics January 14, 2026 10:04
@adinauer adinauer merged commit d4f469f into feat/trace-metrics Jan 14, 2026
59 of 115 checks passed
@adinauer adinauer deleted the 12-18-metrics_counter_basic_api branch January 14, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@markushi markushi markushi approved these changes

@romtsn romtsn Awaiting requested review from romtsn

@lcian lcian Awaiting requested review from lcian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adinauer @markushi